Repository navigation
Fix raster plot handling of segment times where t_start is not zero.
#4790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoeZiminski
wants to merge
39
commits into
main
Choose a base branch
from
fix-raster-plot-segment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+229
−66
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
f1a3365
wip
JoeZiminski e3c603e
update.
JoeZiminski 434d58e
Merge branch 'main' into fix-raster-plot-segment
JoeZiminski b2b6112
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 22c6e16
Tidy up,tests.
JoeZiminski e572373
Tidy
JoeZiminski 0d1745a
Fix linting.
JoeZiminski acf27b0
Small tidy up.
JoeZiminski 1f31ce7
Fix sorting bug, roll out across all plots, remove durations.
JoeZiminski c9e8e77
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3851db2
Update tests.
JoeZiminski 9ead884
Add comment.
JoeZiminski 98143d1
Remove unused var.
JoeZiminski 539b7ed
Fix raster widgets.
JoeZiminski 48ca1c9
Fix rasters.
JoeZiminski 25de7b4
Convert to dict.
JoeZiminski 5ae61c4
Util for conversion to boundaries.
JoeZiminski da4456c
Tidy.
JoeZiminski c000d5b
Linting.
JoeZiminski edf00d4
Remove stuff now in PR 4796.
JoeZiminski 3e9d805
Fix test.
JoeZiminski 033d3a3
Fix tests.
JoeZiminski 244d985
Fix tests....again.
JoeZiminski 6db46de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4c72f0e
Merge branch 'main' into fix-raster-plot-segment
JoeZiminski a416cfe
Dynamically use tick labels.
JoeZiminski 7939950
Remove using get segment times on sorting for now.
JoeZiminski 7d102e2
Use recording times for start/stop times if htey exist in get_segment…
JoeZiminski 14acc79
Linting.
JoeZiminski 5e4bf2f
Remove playing.
JoeZiminski c17bbbb
Minor tidy ups and refactorings.
JoeZiminski 6336bc2
More dynamic ticks.
JoeZiminski 266d837
Think foudn a happy medium with the ticks.
JoeZiminski a34b786
rename compute to estimate.
JoeZiminski e063ecf
Remove some locator formatting as default works pretty well.
JoeZiminski 9a9d3e2
Small doc tidying up.
JoeZiminski 3851e2d
ensure all methods return inclusive stop times.
JoeZiminski eddf608
Linting.
JoeZiminski 02a7b1d
Better handle empty segments.
JoeZiminski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused in main, but I guess this is public facing and will need a deprecation warning? (although maybe not if its never used anyway)