Repository navigation
Fix legacy Mahalanobis metric parameters on load - #4892
Open
AtomicGlance wants to merge 5 commits into
Open
AtomicGlance wants to merge 5 commits into
AtomicGlance wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older saved waveform extractors can retain
isolation_distanceandl_ratioparameter keys after their metric names have been migrated tomahalanobis. This change migrates the parameter keys too. If the legacy configurations disagree, loading continues with theisolation_distanceparameters and emits a warning explaining that choice.The existing legacy-loading regression test checks the migrated keys and verifies that conflicting settings produce the warning without preventing the analyzer from loading.
Validation: the compatibility test module passed locally on Windows (2 passed, 1 skipped). The new conflict case failed with the previous exception and passed after the change. CI is rerunning.
Addresses #4742.