Repository navigation
Conversation
matchLeadingBlockCharacters only recognised a block marker when the next character was a letter, digit or one of `_*[!`, so "> ```" and "> ~~~" were never seen as quoted. Toggling a blockquote off over a fenced code block unquoted the code lines but left the fences quoted. Allow backtick and tilde after the marker, which also covers lines starting with inline code or strikethrough.
🦋 Changeset detectedLatest commit: 11f1949 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184.
Describe your changes
In Markdown mode, toggling a blockquote off over a fenced code block left the fence lines quoted (
> ````), becausematchLeadingBlockCharactersonly treated>as a block marker when the next character was a letter, digit or one of_*[!. This adds backtick and tilde to that lookahead, so> ```` and> ~~~lose their quote like any other line. Lines starting with inline code or strikethrough (`> `x, `> ~~x~~`) now unquote too, and list or heading toggles treat- `x` `` like `- x`. Added unit tests for the multi-line unquote and for `matchLeadingBlockCharacters`, plus a patch changeset.The video shows a fenced block in the Markdown editor being quoted and unquoted with Ctrl-Q, ending on the original block with no
>left on the fences.stacks-editor.mp4
PR Checklist
/** ... */docsbug/enhancementand other labels as appropriateEnvironment(s) tested
Additional context
Fix written with Claude Code; video is an automated browser run of this branch recorded by User Stories Bot.