fix(worker): stop capping VapourSynth's frame cache at 1 GB (#107) - #116
Merged
Merged
Conversation
Both templates set core.max_cache_size = 1024, an eighth of what VapourSynth picks for itself on a 16 GB machine. On HD sources that starved QTGMC's threads: 1080i Very Slow ran at 1.9 fps instead of 14.7. The templates now leave the cache to VapourSynth. Settings -> Output gains "Override max cache size" for anyone who needs a specific limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GLXdGLfPwgYjW1AkonGqN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107.
Problem
Both templates set
core.max_cache_size = 1024. The bundled VapourSynth R78 picks 8192 MB for itself on a 16 GB Mac, so the line cut the cache to an eighth. On HD sources that starves QTGMC's threads; the reporter saw ~1 fps and a log full ofmemory usage still over the limit, flushing pipeline.Bare
haf.QTGMC, synthetic interlaced 4:2:2, bundled vspipe (macos-arm64, 8 threads):SD never reaches the cap, which is why no test noticed.
Change
EncodingSettings.maxCacheSizeMb, MB, off by default) writescore.max_cache_sizeinto both the encode and preview scripts. 0 is treated as off.Testing
test_162: both scripts, with and without the override.integration_filter_parameters_test.dart, model tests inmax_cache_size_test.dart.Not measured: the default VapourSynth picks on Windows/Linux or on an 8 GB machine. The new control has not been checked by eye in the running app.
🤖 Generated with Claude Code
https://claude.ai/code/session_014GLXdGLfPwgYjW1AkonGqN