Repository navigation
perf(map): cache marker icons and look pins up by id - #317
Merged
yakew7 merged 1 commit intoOct 27, 2026
Merged
Conversation
Contributor
|
@propcgamer20-png is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #295. In
ClusteredMarkers:places.find(...)per pin is replaced by aMapbuilt once inuseMemofromplaces.pinIconnow takes a place type and returns one cachedL.DivIconper type (exported for testing).clusterIconis cached by the per-type counts, so a cluster whose contents did not change keeps the same icon object. react-leaflet only callsmarker.setIconwhen the icon object changes, so unchanged pins and clusters are no longer rewritten on everymoveendandzoomend.Markup and styling of pins and clusters are unchanged.
Type of change
Verification
npm run typecheck,npm run lintandnpm run test:unitpass (601 tests, 2 new inmap-view.test.tsx: same instance for the same type, different instance for a different type).L.Marker.prototype.setIconcall counts while panning innpm run dev, so there is no before and after count yet. That acceptance item is still open.Checklist