Repository navigation
American to British: keep phrases (por favor) - #318
Merged
Merged
Conversation
…avour") Built-in <Keep text="..."/> entries in WordList.xml plus the local list's <Ignore> entries (which may now be phrases) are masked before the rules run, so a word inside them is left untouched while still converted elsewhere. Fixes SubtitleEdit/subtitleedit#15946 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SubtitleEdit/subtitleedit#15946 - "por favor" became "por favour".
Plugin-Shared/WordList.xml(<Keep text="por favor" />,faz favor). Kept phrases are masked with private-use placeholders before the word rules run and restored afterwards, so "favor" inside them is untouched while "a favor" still becomes "a favour". Whole-word, case-insensitive, any whitespace between words.<Ignore us="..." />entries now also act as keep phrases, so users can add their own (e.g.<Ignore us="in favor of" />) from the gear button > Ignored words. Same file format as before, SE4-compatible (SE4 just ignores an unknown phrase).Tested with a scratch console against Plugin-Shared:
Do me a favor, por favor, my favorite color.->Do me a favour, por favor, my favourite colour.POR FAVOR!unchanged; BR->USpor favour, a favour->por favor, a favorin favor of:Color me in favor of it, a favor.keeps the phrase, converts the last favor.AmericanToBritish and BritishToAmerican build.
🤖 Generated with Claude Code