[BootstrapAdminUi] Add a body hookable to the create/update content composition#375
Open
vvasiloi wants to merge 1 commit into
Open
[BootstrapAdminUi] Add a body hookable to the create/update content composition#375vvasiloi wants to merge 1 commit into
vvasiloi wants to merge 1 commit into
Conversation
vvasiloi
force-pushed
the
fix/crud-form-page-body
branch
3 times, most recently
from
5b8b084 to
d11100e
Compare
vvasiloi
changed the title
vvasiloi
force-pushed
the
fix/crud-form-page-body
branch
from
d11100e to
9b6b7c3
Compare
Tabler's header-to-content spacing comes from .page-body's top margin against its .page-header sibling. The create/update pages render no .page-body, so the form card sits glued to the sticky header. BC break: form_error_alert and form move from …content.* to …content.body.*.
vvasiloi
force-pushed
the
fix/crud-form-page-body
branch
from
9b6b7c3 to
bca6861
Compare
Contributor
Author
|
CI failures are unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create/update pages render no
.page-body, so the form card sits glued to the sticky page header — the header-to-content spacing in Tabler comes from.page-body's top margin against its.page-headersibling.This adds a
bodyhookable (rendering.page-body) to the create/update content composition;form_error_alertandformmove under it.BC break: hook customizations targeting
sylius_admin.common.{create,update}.content.form*must retarget…content.body.form*— documented in the newUPGRADE.md.