Move pnpm settings to pnpm-workspace.yaml; approve esbuild builds (v0.3.28)#31
Merged
Conversation
The deploy environment's pnpm no longer reads the "pnpm" field in
package.json ("keys were ignored: pnpm.overrides"), so the tiptap
overrides move to pnpm-workspace.yaml — their supported home — where
both pnpm 10 and newer read them. Same resolution; lockfile unchanged.
Also commit the esbuild build-script approval (onlyBuiltDependencies)
so ERR_PNPM_IGNORED_BUILDS stops failing strict installs — esbuild
arrives via tsx/vite and needs its postinstall for the platform binary.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #30 — this commit raced the merge and landed after it, so it's re-landed here.
pnpm-workspace.yaml: the deploy environment's pnpm warnsThe "pnpm" field in package.json is no longer read— meaning the tiptap 3.27.0 overrides from Hotfix: pin TipTap suite to 3.27.0 for deploy release-age policy (v0.3.27) #30 were being ignored there. The lockfile still pins everything concretely (which is why the age-policy failure is fixed either way), but the overrides must live in their supported home to survive future re-resolutions. Same resolution; lockfile content unchanged apart from the settings header.onlyBuiltDependencies): fixesERR_PNPM_IGNORED_BUILDS: esbuild@0.27.4on strict installs. esbuild arrives via tsx/vite (dev tooling, in the lockfile since v0.1.0) and needs its postinstall for the platform binary.167/167 tests; resolution verified unchanged (zero
3.28.0references).🤖 Generated with Claude Code