fix: support multi-head MTP weight mapping in MimoBridge (closes #2131)#2154
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
fix: support multi-head MTP weight mapping in MimoBridge (closes #2131)#2154botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
_convert_mtp_parammethod inMimoBridgeassumes a single MTP layer and has incomplete handling for the transformer_layer sub-components. When--mtp-num-layers > 1, the weight conversion for layers within each MTP block fails because proxy decoder layer indices conflict and the final replacement is missing. This causes crashes during training initialization.Fix
model.mtp_layers.{idx}after using the parent class mapping, ensuring all MTP layer indices are correctly mapped regardless of the number of MTP heads.Closes #2131