[TASK] Speed up MySQL functional database resets - #741
Open
wouter90 wants to merge 1 commit into
Open
Conversation
Functional test cleanup currently truncates every touched MySQL or MariaDB table. TRUNCATE is expensive DDL even for tables without an auto-increment column, where no sequence state needs to be restored. Delete rows from touched tables without auto-increment instead, while retaining TRUNCATE for tables whose counter changed. MySQL may omit the current counter for populated auto-increment tables, so inspect column metadata before selecting DELETE in that ambiguous case. For Extbase RelationTest, this reduces MariaDB 10.4 runtime from about 63.3 to 57.3 seconds and MySQL 8.4 runtime from 112.1 to 100.1 seconds. The complete MariaDB functional suite passes with 12,523 tests and 73,326 assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional test cleanup currently truncates every touched MySQL or MariaDB table. TRUNCATE is expensive DDL even for tables without an auto-increment column, where no sequence state needs to be restored.
Delete rows from touched tables without auto-increment instead, while retaining TRUNCATE for tables whose counter changed. MySQL may omit the current counter for populated auto-increment tables, so inspect column metadata before selecting DELETE in that ambiguous case.
For Extbase RelationTest, this reduces MariaDB 10.4 runtime from about 63.3 to 57.3 seconds and MySQL 8.4 runtime from 112.1 to 100.1 seconds. The complete MariaDB functional suite passes with 12,523 tests and 73,326 assertions.