Skip to content

[TASK] Bulk insert functional database snapshots #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wouter90 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TASK] Bulk insert functional database snapshots #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions Classes/Core/Functional/Framework/DataHandling/Snapshot/DatabaseAccessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,7 @@ private function importTable(string $tableName, array $columns, array $items): v
);
}
$columnNames = array_keys($columns);
foreach ($items as $item) {
$this->connection->insert(
$tableName,
array_combine($columnNames, $item),
$columns
);
}
$this->connection->bulkInsert($tableName, $items, $columnNames, $columns);
// reset table sequences after inserting snapshot data. Dataset contains primary key column data which
// leads to out-of-sync sequence values for some dbms platforms, thus resetting sequence values
// is needed.
Expand All @@ -118,9 +112,8 @@ function (string $columnName) use ($table) {
// Doctrine DBAL v4 converted the `*ParameterType` to an enum, and therefore returning this enum instead
// of the string value like before. As this is a non-baked enum, it cannot be serialized or json_encoded,
// and breaking the snapshot export badly. Due to the requirement to support Doctrine DBAL v3 and v4 it
// is necessary to detect the enum end return the doctrine type name instead. The `Connection->insert()`
// adjustment is adjusted to transform the provided types during import to the correct ParameterType
// again.
// is necessary to detect the enum and return the doctrine type name instead. Connection transforms
// the provided types during import to the correct ParameterType again.
// @see https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-converted-enum-like-classes-to-enums
// @todo Simplify this after Doctine DBAL v3 support can be dropped.
$type = $table->getColumn($columnName)->getType();
Expand Down