test(datagrid): isolate header title-rect padding test from the value-filter funnel#1762
Merged
Merged
Conversation
…-filter funnel Claude-Session: https://claude.ai/code/session_0198faM6VCrViRU4XwRoS1DC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
macOS App Testshas been red onmainsince #1756, failing onlySortableHeaderCellTests:Every PR branched off
maininherits the red job (e.g. #1758, #1760), even when its own changes are unrelated and its other test jobs pass.Root cause
#1756 added the per-column value filter, giving
SortableHeaderCella funnel and a defaultsupportsValueFilter = true.titleRect(forBounds:)now subtractsreservedTrailingWidth(), which reserves the funnel width (13) + spacing (2) + padding (8) = 23pt when the filter is supported. So for a 100pt-wide bounds the title rect is100 − 8 − 23 = 69, not 92.The test builds a default cell (funnel on) but still asserts the old no-funnel width of 92, so it fails deterministically. Real data columns keep
supportsValueFilter = true; only the row-number column sets it false.Fix
The test's purpose is the horizontal padding (the left inset and the
minX == 14/ width assertions), not the funnel, so it now setssupportsValueFilter = falseto isolate that. Width is100 − 8 = 92again. Funnel and indicator reservation are already covered by the sibling tests in the same suite.Test-only change, no user-facing behavior, so no CHANGELOG entry.
https://claude.ai/code/session_0198faM6VCrViRU4XwRoS1DC