Repository navigation
test(linux): check the app at display scales and fix what the pass found - #3826
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux/docs/testing.md(Manual passes, Display scales): GNOME Wayland at 100, 125, 150, 175 and 200%, X11 at 200%, two monitors at 100% and 200% with the window moved between them, KDE Plasma at 125 and 150%, and 150% with Large Text. It ran in the dev container on llvmpipe; a re-run on GPU hardware is in the ROADMAP backlog.app-scale-2test runs the grid, ER diagram, editor view and window geometry tests again withGDK_SCALE=2, so CI's fast job runs them at scale 2.sourceview5::init(). GtkSourceView's stylesheet was never loaded, so the completion list had no background, no gap before a column's type, and no width while its rows were hidden; GDK refuses such a popup, so the list stopped appearing once a word had no match.AdwTabViewmoves the focus only from a page that held it, so text typed after Ctrl+T from the sidebar went to the sidebar's search.table-relation-symbolic(Show ER Diagram) andstatement-pending-symbolic(Not Run) redrawn on the 16 px grid; both had half-pixel edges that were soft at 100%.Test plan
main:the_list_comes_back_after_a_word_with_no_match,a_new_editor_tab_takes_the_focus_from_outside_the_tabs,a_reopened_editor_tab_takes_the_focus,editor_font_css_keeps_a_fractional_size.verify.shbuild,test(every Meson suite,app-scale-2included, as CI's fast job runs them) and lint.Screenshots
Completion list after a word with no match ("stzq", then two Backspaces):
Ctrl+T from the sidebar, then typing
SELECT 42:Show ER Diagram and Not Run icons at 100%, 8 times larger:
GNOME at 125, 150 and 200%, and KDE at 150%:
Fixes #3641