Repository navigation
fix(linux-drivers): count an aggregate's documents for itcount() in MongoDB - #3829
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db.c.aggregate([...]).itcount()in the SQL editor returns the number of documents the pipeline produces, counted on the server with a$groupstage, the wayfind(...).count()already is. feat(linux): connect to MongoDB, browse its collections and run shell statements #3820 refused it as an unsupported cursor method.$outor$mergeis still refused withitcount(): the server takes no stage after one that writes.explain, whether as.explain()or the{explain: true}option, still asks the planner instead.Test plan
an_aggregates_itcount_counts_on_the_server: the plan ends in the$groupstage and is counted;$mergeis refused;{explain: true}still gives an explain.a_find_reads_the_fields_it_projects_in_the_order_it_sorts(requires docker) now also runsaggregate([{$match: ...}]).itcount()against MongoDB and reads 2.-p tablepro-driver-mongodb --all-targets -D warnings,cargo fmt --check.Refs #3646