Repository navigation
fix(tabs): keep a table tab's rows until you reload it - #3848
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GridDisplayCacheBudget(RAM tier) replacesMemoryPressureAdvisor. The pressure halving is gone becausedispatch/source.hsays not to walk existing caches under pressure.ParkedTableLoad). On reconnect only that table tab loads, through the lazy-load gate. Before, a selected query tab gotrunQueryand ran the statement under its caret.canAutoLoadTableTabandTableRowsRefreshPlannow shareholdsUnsavedWork. A changed table no longer reloads under an open cell.canEditActiveResultrefuses edits while a claimed execution is replacing the tab's rows, as the data files grid does while busy. The result used to clear edits staged during the load.isEvicted,evict(for:),QueryTab.loadEpoch,TableRows.discardRowsKeepingMetadataandevictionTask.EvictionTestsdeleted.MainContentCoordinatorLazyLoadTests,MainContentCoordinatorDisplayStateTests,WorkspaceSwitchKeyStateTests,TabSessionRegistryTests,TabSessionRegistryTableRowsTests,TabSessionTests,TableRowsTestsandTableRowsRowLocatorTests.MemoryPressureAdvisorTestsis nowGridDisplayCacheBudgetTests.Test plan
TableTabRowRetentionTests.switchingKeepsEveryTabsRowsswitches through more table tabs than the cache budget, then checks that every tab keeps its rows and none would reload. It fails on main: rows are dropped and the tab reloads.resigningKeyKeepsRowsis a contract test. The old 5 s timer cannot be observed without a fixed sleep, which the test rules forbid.Fixes #3841