Repository navigation
fix(schema): return get_schema_snapshot as the host TableSchema array - #10
Merged
Merged
Conversation
The ER diagram deserializes get_schema_snapshot straight into
Vec<TableSchema>, so the {tables, columns, foreign_keys} envelope failed
with "invalid type: map, expected a sequence" and the window only ever
showed a load error. Return one {name, columns, foreign_keys} entry per
table; an empty schema is now [].
Also point just dev-install/uninstall at the kind-first
plugins/drivers/libsql bundle, since the host resolves drivers before
flat bundles and shadowed the old flat path.
Bump to 1.0.3.
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
- README: fix the pagination claim (no total row count), document file: URIs, ssl_mode scheme rules, triggers and the snapshot shape that powers the ER diagram; move install steps to plugins/drivers/libsql and add the release-archive path. - AGENTS.md: add the project guide, including the dev-install location and the get_schema_snapshot contract. - CHANGELOG: point the 1.0.3 link at its release tag, matching older entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening the ER diagram on a libSQL connection always failed with
Failed to load diagram: invalid type: map, expected a sequence.Tabularis deserializes
get_schema_snapshotstraight intoVec<TableSchema>(
src-tauri/src/plugins/driver.rs), but this plugin returned a{tables, columns, foreign_keys}envelope.plugins/PLUGIN_GUIDE.mdand thecreate-pluginRust template both specify an array of{name, columns, foreign_keys}.Fix
get_schema_snapshotnow returns one{name, columns, foreign_keys}entryper table (
schema_snapshot_for); an empty schema returns[].fields, and the empty-schema case.
just dev-install/uninstallnow target the kind-firstplugins/drivers/libsqlbundle on Linux, macOS and Windows. Tabularisresolves
drivers/<id>before flat bundles, so the old flat path wasshadowed by an installed copy.
Cargo.toml,Cargo.lock,.tabularium,CHANGELOG.md).Verification
cargo test --locked --all-targets: 100 passed (2 new)just lint(clippy with-D warnings) andjust fmt: cleandemo/tabularis_demo.dbreturns"result":[{...}],confirmed with the installed plugin binary as well.
Tag
v1.0.3after merge to run the release workflow.