feat(plugins): forward external batch query RPC#443
Open
haos666 wants to merge 5 commits into
Open
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous Review Summary (commit 4630aa7)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4630aa7)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by kimi-k2.6 · Input: 23.9K · Output: 2.6K · Cached: 77.8K |
Merge from main left two copies of the helper, breaking cargo test compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RpcDriver::execute_batchto call an external plugin'sexecute_query_batchJSON-RPC method when available.execute_queryloop when the plugin returns method-not-found.Context
This is the next focused follow-up from #316 after trigger forwarding and Oracle/DM splitter support. It lets external plugins that implement
execute_query_batchpreserve a single plugin-managed connection/session across multi-statement execution, while older plugins continue using the existing fallback behavior.Validation
cargo test plugins::driver --manifest-path src-tauri/Cargo.tomlcorepack pnpm exec vitest run- 147 files / 2767 tests passedcorepack pnpm run typecheckcorepack pnpm run lint- passed with the existingSettingsProvider.tsxhook dependency warningcorepack pnpm run buildTMPDIR=/tmp corepack pnpm run test:rust- 797 passed / 1 ignored; integration tests remain ignored by defaultNote: running
corepack pnpm run test:rustwithoutTMPDIR=/tmpfailed locally only because the askpass Unix socket path exceededSUN_LENin the default macOS temp directory. The same suite passed with a shorter temp dir.