Skip to content

feat(plugins): forward external batch query RPC#443

Open
haos666 wants to merge 5 commits into
TabularisDB:mainfrom
haos666:haos666/external-plugin-batch-forwarding
Open

feat(plugins): forward external batch query RPC#443
haos666 wants to merge 5 commits into
TabularisDB:mainfrom
haos666:haos666/external-plugin-batch-forwarding

Conversation

@haos666

@haos666 haos666 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Override RpcDriver::execute_batch to call an external plugin's execute_query_batch JSON-RPC method when available.
  • Preserve graceful compatibility by falling back to the existing sequential execute_query loop when the plugin returns method-not-found.
  • Emit existing per-statement progress callbacks for both native plugin batch results and fallback results.

Context

This is the next focused follow-up from #316 after trigger forwarding and Oracle/DM splitter support. It lets external plugins that implement execute_query_batch preserve a single plugin-managed connection/session across multi-statement execution, while older plugins continue using the existing fallback behavior.

Validation

  • cargo test plugins::driver --manifest-path src-tauri/Cargo.toml
  • corepack pnpm exec vitest run - 147 files / 2767 tests passed
  • corepack pnpm run typecheck
  • corepack pnpm run lint - passed with the existing SettingsProvider.tsx hook dependency warning
  • corepack pnpm run build
  • TMPDIR=/tmp corepack pnpm run test:rust - 797 passed / 1 ignored; integration tests remain ignored by default

Note: running corepack pnpm run test:rust without TMPDIR=/tmp failed locally only because the askpass Unix socket path exceeded SUN_LEN in the default macOS temp directory. The same suite passed with a shorter temp dir.

@kilo-code-bot

kilo-code-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • src-tauri/src/plugins/driver.rs
Previous Review Summary (commit 4630aa7)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 4630aa7)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • src-tauri/src/plugins/driver.rs

Reviewed by kimi-k2.6 · Input: 23.9K · Output: 2.6K · Cached: 77.8K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants