fix(data-grid): open dedicated editor for array cells on double-click#489
Open
Davydhh wants to merge 2 commits into
Open
fix(data-grid): open dedicated editor for array cells on double-click#489Davydhh wants to merge 2 commits into
Davydhh wants to merge 2 commits into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by kimi-k2.6 · Input: 79.2K · Output: 11K · Cached: 710.7K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Double-clicking a cell whose value is an array (e.g. a Postgres
uuid[]/text[]column) opened the inline<textarea>editor. That editor rendersString(array), cramming the values into a comma-joined string inside a~120px-tall scrollable box — awkward to read and edit.
The grid was also internally inconsistent: array cells already render as
JSON cells (with the JSON affordance), but editing them fell through to the
plain-text path.
Fix
Route array cells through the same dedicated JSON viewer window that
json/jsonbcolumns already use on double-click.