fix(QTDI-3014): bump netty to 4.1.135.Final#1241
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Netty version used by the component-runtime-http-junit testing module and adjusts Spark test dependency exclusions to avoid bringing io.netty artifacts transitively from spark-core in a couple of test-focused modules.
Changes:
- Bump
component-runtime-http-junit’snetty.versionproperty to4.1.135.Final. - Exclude transitive
io.netty:*artifacts fromorg.apache.spark:spark-core_*in two modules’ test dependencies.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| singer-parent/component-kitap/pom.xml | Excludes transitive io.netty artifacts from the spark-core test dependency. |
| component-runtime-testing/component-runtime-testing-spark/pom.xml | Excludes transitive io.netty artifacts from the spark-core test dependency. |
| component-runtime-testing/component-runtime-http-junit/pom.xml | Updates netty.version to 4.1.135.Final for the HTTP JUnit testing module (and its shaded Netty usage). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)
ozhelezniak-talend
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Why this PR is needed?
QTDI-3014
What does this PR adds (design/code thoughts)?
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code