Skip to content

ci: use a supported runner for Playwright - #582

Open
tannerlinsley wants to merge 1 commit into
mainfrom
codex/playwright-supported-runner
Open

tannerlinsley wants to merge 1 commit into
mainfrom
codex/playwright-supported-runner

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Use Ubuntu 24.04 for jobs that install Playwright browsers. The locked Playwright version supports that image, while ubuntu-latest now selects an unsupported Ubuntu 26.04 image.

AI review notes:
PR #581's hosted browser job failed before running tests with Playwright does not support ffmpeg on ubuntu26.04-x64: https://github.com/TanStack/cli/actions/runs/44559519483/job/135684644663

Playwright 1.58.2's installed browser registry includes Ubuntu 24.04 support. This pins the PR browser job, opportunistic matrix and release job to that supported image. All commands, tests, review requirements and permissions remain unchanged. No dependency or workflow action is upgraded.

Local validation uses the normal repository build, unit and blocking browser commit hooks. Those run on macOS and do not prove the Linux browser-install step; the hosted PR job is the required confirmation. The release workflow is inspected only, no release is triggered for validation.

Summary by CodeRabbit

  • Chores
    • Updated CI and release workflows to run selected jobs on a newer Ubuntu runner image.
    • Workflow triggers, steps, permissions, and release behavior remain unchanged.

@tannerlinsley
tannerlinsley requested a review from a team as a code owner November 19, 2026 15:57
@changeset-bot

changeset-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 961a9fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

This pull request updates three GitHub Actions jobs to use ubuntu-24.04 instead of ubuntu-latest. It changes the E2E opportunistic matrix job, the blocking E2E PR job, and the release job. The provided summaries show no other workflow changes.

Changes: CI runner image updates

Layer / File(s) Summary
Pin workflow jobs to ubuntu-24.04
.github/workflows/e2e-opportunistic-matrix.yml, .github/workflows/pr.yml, .github/workflows/release.yml
The matrix-e2e, test-e2e, and release jobs now set runs-on to ubuntu-24.04 instead of ubuntu-latest. The provided summaries show no other edits to triggers, steps, permissions, matrix settings, or release conditions.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested reviewers: alemtuzlak

Merge Risk: Minimal · up to 961a9

This pins CI and release jobs to a supported Ubuntu 24.04 runner so Playwright browser installs stop failing on the unsupported 26.04 image. No actionable merge risk remains. The hosted PR job will confirm the fix.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: use a supported runner for Playwright" matches the main change. The PR moves the jobs that install Playwright browsers from ubuntu-latest to ubuntu-24.04, because the locked Playwright …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: use a supported runner for Playwright" matches the main change. The PR moves the jobs that install Playwright browsers from ubuntu-latest to ubuntu-24.04, because the locked Playwright version does not support the Ubuntu 26.04 image that ubuntu-latest now resolves to. The title is specific and concise, and it follows a conventional commit style.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 55bdd8c2-a2bf-4bce-acc5-c3fc5337be7e
Commits

Reviewing files that changed from the base of the PR and between 40e0043 and 961a9fc.

Files selected for processing: 3

  • .github/workflows/e2e-opportunistic-matrix.yml
  • .github/workflows/pr.yml
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant