Skip to content

setup: switch to voidzero-dev/setup-vp#398

Merged
lachlancollins merged 4 commits into
mainfrom
vite-plus
Jul 3, 2026
Merged

setup: switch to voidzero-dev/setup-vp#398
lachlancollins merged 4 commits into
mainfrom
vite-plus

Conversation

@lachlancollins

@lachlancollins lachlancollins commented Jun 30, 2026

Copy link
Copy Markdown
Member

🎯 Changes

In addition to handling the basics like installing Node and pnpm, this action also installs the global vp CLI.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Streamlined the repository setup workflow into a single “Setup Vite+” step using the Node version from .nvmrc.
    • Automatically runs dependency installation during setup, with caching explicitly turned off.
    • Keeps the separate step that installs pnpm globally as part of the setup process.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 74dc5f43-5b68-4b90-ba6d-333b63843a4d

📥 Commits

Reviewing files that changed from the base of the PR and between 4891f0a and 91451ea.

📒 Files selected for processing (1)
  • .github/setup/action.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/setup/action.yml

📝 Walkthrough

Walkthrough

The composite GitHub Action setup was consolidated into a single voidzero-dev/setup-vp step using .nvmrc, run-install: true, and cache: false, with a separate global pnpm install step retained.

Changes

CI Setup Action Update

Layer / File(s) Summary
Consolidate setup into single action step
.github/setup/action.yml
Replaces pnpm setup, Node setup, and frozen-lockfile install steps with one "Setup Vite+" step using voidzero-dev/setup-vp, .nvmrc, run-install: true, and cache: false, and adds a step that installs pnpm globally with vp install -g pnpm.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change to the setup action.
Description check ✅ Passed The description follows the required template and includes the change summary, checklist, and release impact section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vite-plus

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/setup/action.yml:
- Around line 6-11: The Setup Vite+ action currently enables run-install without
preserving frozen-lockfile behavior, which can let CI succeed with an
out-of-date lockfile. Update the setup in the action configuration for the
setup-vp step to pass the frozen-lockfile flag explicitly through run-install so
installs remain locked, using the existing Setup Vite+ action block as the place
to adjust the with settings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 206606b8-9d4c-4954-97c0-1d709d2da641

📥 Commits

Reviewing files that changed from the base of the PR and between b313637 and 3661dcf.

📒 Files selected for processing (1)
  • .github/setup/action.yml

Comment thread .github/setup/action.yml
@nx-cloud

nx-cloud Bot commented Jun 30, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 91451ea

Command Status Duration Result
nx run-many --target=build ✅ Succeeded <1s View ↗
nx affected --targets=test:sherif,test:docs,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-03 18:49:05 UTC

@nx-cloud

nx-cloud Bot commented Jun 30, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 4891f0a

Command Status Duration Result
nx affected --targets=test:sherif,test:docs,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-30 22:26:23 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jun 30, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@tanstack/eslint-config@398
npm i https://pkg.pr.new/@tanstack/publish-config@398
npm i https://pkg.pr.new/@tanstack/typedoc-config@398
npm i https://pkg.pr.new/@tanstack/vite-config@398

commit: 91451ea

@lachlancollins lachlancollins requested a review from a team July 1, 2026 22:18
@lachlancollins lachlancollins merged commit 695e782 into main Jul 3, 2026
10 checks passed
@lachlancollins lachlancollins deleted the vite-plus branch July 3, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants