Skip to content

fix(db): canonicalize loadSubset demand identity #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyleAMathews wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(db): canonicalize loadSubset demand identity #1768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bfaa49
Apply canonical demand identity review fixes
KyleAMathews Aug 24, 2026
1d003a4
docs: add canonical demand identity changeset
KyleAMathews Aug 24, 2026
53c270c
fix(db): fall back when runtime crypto is incomplete
KyleAMathews Aug 25, 2026
bdf9d7a
fix(db): preserve observable demand identity
KyleAMathews Aug 25, 2026
1384a47
fix(db): address demand identity review findings
KyleAMathews Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/canonical-demand-identity.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@tanstack/db': patch
'@tanstack/query-db-collection': patch
---

Canonicalize equivalent loadSubset queries to one demand identity while preserving observable output aliases, exact projected values, and distinct ordered windows. Query DB now reuses the same canonical identity for its on-demand cache keys.
5 changes: 5 additions & 0 deletions packages/db/src/query/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,13 @@ export { type LiveQueryCollectionUtils } from './live/collection-config-builder.
export {
UnhashableQueryIRError,
canonicalizeQueryIR,
getLoadSubsetDemandKey,
getQueryIdentity,
getStableQueryBuilderHash,
getStableQueryIRHash,
getStableValueHash,
type DemandKey,
type QueryIdentity,
} from './ir-stable-identity.js'

// Predicate utilities for predicate push-down
Expand All @@ -112,6 +116,7 @@ export {
isLimitSubset,
isOffsetLimitSubset,
isPredicateSubset,
isLoadSubsetRequestSubsumedBy,
} from './predicate-utils.js'

export { DeduplicatedLoadSubset } from './subset-dedupe.js'
Loading
Loading