[v2] chore(examples): devtools and StrictMode in every React example - #2406
dasjideepak wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: TanStack/form/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughSeveral React examples add TanStack Form Devtools. Other examples change devtools visibility or enable React Strict Mode. ChangesReact Devtools examples
React Strict Mode examples
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The PR adds Form Devtools, changes their visibility, and enables Strict Mode in React examples. Inspection found no concrete defect requiring resolution, so no material merge risk remains. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new devtools UI is confined to examples. The reviewed components do not receive page data or gain server-action authority. No introduced security issue was identified, but incomplete coverage prevents a negligible-risk conclusion. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
Part of #2305. This covers the devtools item ("Include
TanStackDevtoolsin every example withhideUntilHover: false") and StrictMode in every example.Devtools
hideUntilHover: true→falseinreact/simple,react/large-form,react/multi-step-wizardandreact/query-integration, the only React examples still hiding the panel.react/compiler, set up the same way asreact/simple:TanStackDevtoolswithformDevtoolsPlugin(), rendered next to<App />.react/next-server-actionsandreact/next-server-actions-zod, reusing the'use client'Devtoolscomponent fromreact/nextjsand rendering it inpage.tsxnext toClientComp.pnpm-lock.yamlonly gains those entries.StrictMode (second commit)
<App />inReact.StrictModein the 6 Vite examples that rendered without it:array,basic,basic-splitting-form,field-groups,ui-integration-dnd-kitandui-integration-shadcn, same pattern assimpleandlarge-form.react/nextjs: setreactStrictMode: trueinnext.config.ts, matching the two server-actions examples.react/expo:index.tsregisters a smallRootthat rendersAppinsideStrictMode(createElement, since the entry is.ts).compiler,large-form,multi-step-wizard,query-integration,simple,standard-schema, andtanstack-start(Start's default client entry hydrates inside<StrictMode>). The other frameworks have no StrictMode equivalent.Not included:
alpha,@tanstack/solid-form-devtoolscurrently exports only a placeholder, so there's no form plugin to add yet. Happy to follow up once it lands.react/expo. The web devtools panel doesn't apply to React Native.I built all 7 devtools examples locally (
vite buildandnext build), and rantscplusvite buildon each StrictMode example (tscfornextjsandexpo).pnpm test:sherif,pnpm test:knip, eslint and prettier pass on the changed files.✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request. (Examples only; I built each changed example and ran sherif, knip, eslint and prettier.)🚀 Release Impact
@LeCarbonator, ready for review whenever you get to it. It's independent of #2405 and doesn't touch the same files. (StrictMode was briefly a separate PR, #2409; I moved it here to keep the series smaller.)
Summary by CodeRabbit