Skip to content

Gap CLI: a partial or daemon run can draw other drawn bases than a cold run without --seed #155

Open

Description

@KyleAMathews

In the gap CLI, a property's drawn bases (#122, histories.drawnBases) can differ between a cold whole-file run and a partial or daemon run, when the CLI runs with no --seed. Found by reading (review of #122, round 2, G6). It is not reproduced yet.

  • Where R comes from: a fixed-seed constructed unit draws its drawn bases from R + k. R is the run's random seed: the first unit that uses it draws it from Math.random, through oracleCampaignSeed (src/oracle-config.ts).
  • The capture: it seeds Math.random per test, by the test's key (oracle-gaps/capture-setup.mjs, installRandom). So R is a function of which test is the first to call runSeed in that process.
  • The failure: in a cold whole-file run, that is the property's first drawing fixed-seed unit. If a partial run, a daemon check, or a batch copy runs a set of tests whose first drawing unit is a different one, it draws another R. A later unit's drawn bases then differ from the baseline's. Then:
    • unchanged code can read as changed (a false kill, or not-judged);
    • a verdict on a drawn base can be credited on the fixed seed route (a reproducible route, P3, G2, I8) when a cold run doesn't repeat it.
  • Not affected: with --seed, ${envPrefix}_SEED fixes R in every run, and the drawn bases are the same.
  • In this repository today: the gap e2e oracle and the self-oracle draw bases (1 each, and the e2e oracle draws none on win32). No oracle that the gap CLI judges in CI draws bases.

Ask, oracle-first:

  1. A gap-report witness: a property with drawnBases, judged cold and through the daemon (or partially) with no --seed. It should show whether the classes match.
  2. If they differ, a fix that makes R independent of test order inside the CLI. For example, the CLI could always set ${envPrefix}_SEED for a check, choosing and printing one when --seed is absent. Or it could seed oracleCampaignSeed's draw from the property id rather than from the first test's key.

This issue was written by Isaac.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions