Skip to content

chore({svelte-pacer,svelte-pacer-devtools}/eslint.config): export 'defineConfig' result directly - #303

Merged
sukvvon merged 1 commit into
mainfrom
chore/svelte-eslint-config-direct-export
Oct 25, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/svelte-eslint-config-direct-export

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Export the defineConfig result directly in the svelte-pacer and svelte-pacer-devtools ESLint configs instead of assigning it to an intermediate config variable.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Refactor
    • Simplified the linting configuration across the development tools and core packages. This is an internal maintenance change; it does not alter the app’s features or behavior visible to end users.

@sukvvon sukvvon self-assigned this Oct 25, 2026
@changeset-bot

changeset-bot Bot commented Oct 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7c88cab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloud Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7c88cab

Command Status Duration Result
nx run-many --targets=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-25 02:20:08 UTC

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d1694fa and 7c88cab.

Files selected for processing: 2
  • packages/svelte-pacer-devtools/eslint.config.js
  • packages/svelte-pacer/eslint.config.js

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

Both Svelte packages now export their ESLint configuration directly from defineConfig. The intermediate config variables and separate default export statements were removed.

Changes: Svelte ESLint configs

Layer / File(s) Summary
Direct config exports
packages/svelte-pacer/eslint.config.js, packages/svelte-pacer-devtools/eslint.config.js
Each ESLint config now exports the defineConfig result directly instead of assigning it to a local variable and exporting it separately.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • TanStack/pacer#301: Adds the Svelte ESLint config pattern that this change updates in both packages.

Suggested reviewers: kevinvandy

Merge Risk: Minimal · up to 7c88c

No actionable merge risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: exporting the defineConfig result directly from both ESLint configuration files.
Description check Passed The description includes all required sections, explains the change and motivation, completes the checklist, and identifies the change as dev-only with no release impact.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 25, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-pacer

npm i https://pkg.pr.new/@tanstack/alpine-pacer@303

@tanstack/angular-pacer

npm i https://pkg.pr.new/@tanstack/angular-pacer@303

@tanstack/angular-pacer-devtools

npm i https://pkg.pr.new/@tanstack/angular-pacer-devtools@303

@tanstack/ember-pacer

npm i https://pkg.pr.new/@tanstack/ember-pacer@303

@tanstack/lit-pacer

npm i https://pkg.pr.new/@tanstack/lit-pacer@303

@tanstack/octane-pacer

npm i https://pkg.pr.new/@tanstack/octane-pacer@303

@tanstack/pacer

npm i https://pkg.pr.new/@tanstack/pacer@303

@tanstack/pacer-devtools

npm i https://pkg.pr.new/@tanstack/pacer-devtools@303

@tanstack/pacer-lite

npm i https://pkg.pr.new/@tanstack/pacer-lite@303

@tanstack/preact-pacer

npm i https://pkg.pr.new/@tanstack/preact-pacer@303

@tanstack/preact-pacer-devtools

npm i https://pkg.pr.new/@tanstack/preact-pacer-devtools@303

@tanstack/react-pacer

npm i https://pkg.pr.new/@tanstack/react-pacer@303

@tanstack/react-pacer-devtools

npm i https://pkg.pr.new/@tanstack/react-pacer-devtools@303

@tanstack/solid-pacer

npm i https://pkg.pr.new/@tanstack/solid-pacer@303

@tanstack/solid-pacer-devtools

npm i https://pkg.pr.new/@tanstack/solid-pacer-devtools@303

@tanstack/svelte-pacer

npm i https://pkg.pr.new/@tanstack/svelte-pacer@303

@tanstack/svelte-pacer-devtools

npm i https://pkg.pr.new/@tanstack/svelte-pacer-devtools@303

@tanstack/vue-pacer

npm i https://pkg.pr.new/@tanstack/vue-pacer@303

@tanstack/vue-pacer-devtools

npm i https://pkg.pr.new/@tanstack/vue-pacer-devtools@303

commit: 7c88cab

@sukvvon
sukvvon merged commit 34d6213 into main Oct 25, 2026
12 checks passed
@sukvvon
sukvvon deleted the chore/svelte-eslint-config-direct-export branch October 25, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant