Skip to content

fix(solid-pacer-devtools): pass 'theme' and 'devtoolsOpen' to the panel reactively - #305

Open
sukvvon wants to merge 1 commit into
mainfrom
fix/solid-pacer-devtools-panel-reactivity
Open

fix(solid-pacer-devtools): pass 'theme' and 'devtoolsOpen' to the panel reactively#305
sukvvon wants to merge 1 commit into
mainfrom
fix/solid-pacer-devtools-panel-reactivity

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

🎯 Changes

resolvePanelProps read props.theme and props.devtoolsOpen once when PacerDevtoolsPanel was created and passed plain values to the panel, so later changes to these props never reached it.

const [theme, setTheme] = createSignal<'light' | 'dark'>('light')

<PacerDevtoolsPanel theme={theme()} />

setTheme('dark') // the panel keeps receiving 'light'
  • Return getters for theme and devtoolsOpen, so the panel reads the current props, keeping the 'dark' and false defaults.
  • Add tests/panel-reactivity.test.tsx covering prop updates and defaults.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Bug Fixes
    • The devtools panel now reflects changes to its theme and open state while it is active.
    • Default behavior remains a dark theme with the panel closed when these settings aren’t provided.

@sukvvon sukvvon self-assigned this Oct 25, 2026
@changeset-bot

changeset-bot Bot commented Oct 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9ad501a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/solid-pacer-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/solid-pacer-devtools 0.8.1 → 0.8.2 Changeset

@nx-cloud

nx-cloud Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 9ad501a

Command Status Duration Result
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-25 03:17:13 UTC

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 34d6213 and 9ad501a.

Files selected for processing: 3
  • .changeset/solid-pacer-devtools-panel-reactivity.md
  • packages/solid-pacer-devtools/src/SolidPacerDevtools.tsx
  • packages/solid-pacer-devtools/tests/panel-reactivity.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

Walkthrough

resolvePanelProps now exposes theme and devtoolsOpen as getters that read their current values from props. Tests cover signal updates and the defaults, dark and false.

Changes: Solid Pacer devtools panel reactivity

Layer / File(s) Summary
Reactive panel props and validation
packages/solid-pacer-devtools/src/SolidPacerDevtools.tsx, packages/solid-pacer-devtools/tests/panel-reactivity.test.tsx, .changeset/solid-pacer-devtools-panel-reactivity.md		 theme and devtoolsOpen are getters that read from props. Tests check updated values and the dark and false defaults. A patch changeset records the update.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: kevinvandy

Merge Risk: Minimal · up to 9ad50

The change is mergeable with no actionable risk identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the reactive propagation of theme and devtoolsOpen to the Solid Pacer devtools panel.
Description check Passed The description includes the required Changes, Checklist, and Release Impact sections. It explains the issue, the implementation, the tests, and the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 25, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-pacer

npm i https://pkg.pr.new/@tanstack/alpine-pacer@305

@tanstack/angular-pacer

npm i https://pkg.pr.new/@tanstack/angular-pacer@305

@tanstack/angular-pacer-devtools

npm i https://pkg.pr.new/@tanstack/angular-pacer-devtools@305

@tanstack/ember-pacer

npm i https://pkg.pr.new/@tanstack/ember-pacer@305

@tanstack/lit-pacer

npm i https://pkg.pr.new/@tanstack/lit-pacer@305

@tanstack/octane-pacer

npm i https://pkg.pr.new/@tanstack/octane-pacer@305

@tanstack/pacer

npm i https://pkg.pr.new/@tanstack/pacer@305

@tanstack/pacer-devtools

npm i https://pkg.pr.new/@tanstack/pacer-devtools@305

@tanstack/pacer-lite

npm i https://pkg.pr.new/@tanstack/pacer-lite@305

@tanstack/preact-pacer

npm i https://pkg.pr.new/@tanstack/preact-pacer@305

@tanstack/preact-pacer-devtools

npm i https://pkg.pr.new/@tanstack/preact-pacer-devtools@305

@tanstack/react-pacer

npm i https://pkg.pr.new/@tanstack/react-pacer@305

@tanstack/react-pacer-devtools

npm i https://pkg.pr.new/@tanstack/react-pacer-devtools@305

@tanstack/solid-pacer

npm i https://pkg.pr.new/@tanstack/solid-pacer@305

@tanstack/solid-pacer-devtools

npm i https://pkg.pr.new/@tanstack/solid-pacer-devtools@305

@tanstack/svelte-pacer

npm i https://pkg.pr.new/@tanstack/svelte-pacer@305

@tanstack/svelte-pacer-devtools

npm i https://pkg.pr.new/@tanstack/svelte-pacer-devtools@305

@tanstack/vue-pacer

npm i https://pkg.pr.new/@tanstack/vue-pacer@305

@tanstack/vue-pacer-devtools

npm i https://pkg.pr.new/@tanstack/vue-pacer-devtools@305

commit: 9ad501a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon