Repository navigation
Conversation
The open-ended >= range lets solid-js 2.0.0 satisfy the peer once it is released, but these adapters are built for Solid 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2
🦋 Changeset detectedLatest commit: f8196cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
 |
| Layer / File(s) | Summary |
|---|---|
Cap Solid peer dependency ranges packages/solid-pacer-devtools/package.json, packages/solid-pacer/package.json, .changeset/solid-js-peer-cap.md |
Both packages replace open-ended >= peer ranges with caret ranges for version 1. The changeset records the updates. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Suggested reviewers: kevinvandy
Merge Risk: 
e2176
-
The scoped dependency updates are ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Resolution Description check The description explains the motivation and implementation, but it omits the required Release Impact section and most checklist items from the repository template. It also does not explicitly mark the… Add the complete template sections. Include the Contributing guide, test applicability, and AI-assistance checklist items. Add the Release Impact section and mark that the change affects published code and includes a changeset. -
Check name Status Explanation Title check The title clearly and concisely identifies the main change: capping the Solid.js peer dependency range at version 1. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Full details: Description check
-
Explanation
The description explains the motivation and implementation, but it omits the required Release Impact section and most checklist items from the repository template. It also does not explicitly mark the changeset checklist item.
Resolution
Add the complete template sections. Include the Contributing guide, test applicability, and AI-assistance checklist items. Add the Release Impact section and mark that the change affects published code and includes a changeset.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🎯 Changes
The Solid packages here declare an open-ended
solid-jspeer (>=1.x). Solid 2.0.0 is due shortly. Once it's taggedlatest, that range will accept it, sonpm installwill pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removessolid-js/store,createComputed,mergeProps/splitProps,onMount,batchand more.This PR changes each range from
>=Xto^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way@tanstack/solid-router2.x and@tanstack/solid-query6.x did it.Prereleases (
2.0.0-rc.*) never matched>=1.x, which is why nobody has run into this yet.✅ Checklist
peerDependenciesranges and a changeset change; no code changes.Summary by CodeRabbit
solid-jspeer dependency ranges for the Solid Pacer packages to accept Solid 1 versions only. Solid 2 versions are no longer included in the declared compatibility range, helping package managers identify version mismatches during dependency resolution.