Solid router v2 pre main sync#7517
Conversation
Put Start project setup in a single onboarding path for React and Solid while preserving old quick-start URLs with redirects.
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
Co-authored-by: schiller-manuel <schiller-manuel@users.noreply.github.com> Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
github-actions
Bot
added
package: nitro-v2-vite-plugin
package: solid-router-ssr-query
package: vue-router
package: vue-router-devtools
package: vue-router-ssr-query
package: vue-start-client
package: start-fn-stubs
package: vue-start
package: vue-start-server
package: react-start-rsc
package: eslint-plugin-start
labels
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Bundle Size Benchmarks
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
More templates
@tanstack/arktype-adapter
@tanstack/eslint-plugin-router
@tanstack/eslint-plugin-start
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-rsc
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr-query
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-fn-stubs
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/vue-router
@tanstack/vue-router-devtools
@tanstack/vue-router-ssr-query
@tanstack/vue-start
@tanstack/vue-start-client
@tanstack/vue-start-server
@tanstack/zod-adapter
commit: |
Merging this PR will not alter performance
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | ssr request loop (vue) |
420.3 ms | 481.1 ms | -12.64% |
| ⚡ | client-side navigation loop (solid) |
72.6 ms | 66.3 ms | +9.56% |
| ⚡ | ssr request loop (solid) |
174.6 ms | 161.5 ms | +8.14% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing solid-router-v2-pre-main-sync (c67f88d) with solid-router-v2-pre (67a9040)2
Footnotes
-
1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩
-
No successful run was found on
solid-router-v2-pre(5b9145d) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We corrected a misplaced eslint-disable-next-line comment in GenericHydrate.tsx that was suppressing an opening parenthesis line rather than the (isServer ?? typeof window === 'undefined') expression that triggered the @typescript-eslint/no-unnecessary-condition errors. Replacing it with an inline // eslint-disable-line on the expression itself — consistent with all other usages of the same pattern in the file — resolves both lint errors and the spurious "unused disable directive" warning.
diff --git a/packages/solid-start-client/src/GenericHydrate.tsx b/packages/solid-start-client/src/GenericHydrate.tsx
index 42b8d3c7..4a54e5c8 100644
--- a/packages/solid-start-client/src/GenericHydrate.tsx
+++ b/packages/solid-start-client/src/GenericHydrate.tsx
@@ -327,13 +327,10 @@ export function GenericHydrate(props: InternalHydrateProps) {
Solid.createRenderEffect(
() =>
!(
- // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
- (
- (isServer ?? typeof window === 'undefined') ||
- gate.resolved ||
- initialHydrateStrategy._t === 'never' ||
- shouldDeferHydration(initialHydrateStrategy)
- )
+ (isServer ?? typeof window === 'undefined') || // eslint-disable-line @typescript-eslint/no-unnecessary-condition
+ gate.resolved ||
+ initialHydrateStrategy._t === 'never' ||
+ shouldDeferHydration(initialHydrateStrategy)
),
(shouldResolve) => {
if (shouldResolve) {
Or Apply changes locally with:
npx nx-cloud apply-locally xq40-pUjT
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
No description provided.