Repository navigation
fix(react-store): preserve RSC client boundaries - #391
Conversation
🦋 Changeset detectedLatest commit: 114dedf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
View your CI Pipeline Execution ↗ for commit 114dedf
☁️ Nx Cloud last updated this comment at |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
@tanstack/angular-store
@tanstack/lit-store
@tanstack/octane-store
@tanstack/preact-store
@tanstack/react-store
@tanstack/solid-store
@tanstack/store
@tanstack/svelte-store
@tanstack/vue-store
commit: |
🎯 Changes
React Store's alpha selector imports
useRefanduseSyncExternalStoredirectly from React. In an RSC graph these resolve to React'sreact-serverentry, which does not export them. This breaks the production Rsbuild RSC build in TanStack Router #8657.Mark all seven React hook/context modules with
'use client', preserving the boundary in both published ESM and CJS output. Keep the mixed package barrel unmarked so its corecreateAtom,createStore, andbatchreexports remain callable in Server Components. Ordinary SSR continues to execute the existing hooks and server snapshots.Validation:
renderToStringexercises every React API family, returns the expected values, and creates no subscriptions.pnpm test:pr --base=origin/alpha: all 108 tasks pass, including runtime, TypeScript matrix, lint, package builds, and examples.✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request.🚀 Release Impact
The patch changeset is verified with Changesets 3 to produce
@tanstack/react-store@1.0.0-alpha.1on the alpha branch.