fix sorting replacement in single-sort mode#6431
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d2fb560
☁️ Nx Cloud last updated this comment at |
What changed
Why
toggleSorting(..., false)previously kept the other sorted columns when the target column was already the final entry. The action was classified as a toggle, and the toggle path mapped over the entire previous state.Single-sort actions should leave at most the selected column in the sorting state, regardless of its prior position.
Validation
packages/table-core/tests/unit/features/row-sorting/rowSortingFeature.utils.test.ts— 47 tests passedgit diff --checkCloses #4309