fix(table-core): restore aggregate cell fallback - #6585
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (17)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughAggregated-cell rendering now uses a shared table-core helper. It prioritizes ChangesAggregated cell fallback
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Aggregated cells now use an explicit aggregate renderer when present, otherwise preserve custom cell formatting before using the default aggregate formatter. The change is covered by core regression tests and is ready to merge. Sequence Diagram(s)sequenceDiagram
participant FrameworkFlexRender
participant TableCore
participant ColumnDefinition
FrameworkFlexRender->>TableCore: getAggregatedCellRender(cell)
TableCore->>ColumnDefinition: inspect aggregatedCell and cell
ColumnDefinition-->>TableCore: return configured renderer or no renderer
TableCore-->>FrameworkFlexRender: return renderer or formatted aggregate fallback
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
Closes #5778.
aggregatedCellrenderer sogetDefaultColumnDefno longer reports one.aggregatedCell, then customcell, then the default aggregate formatter.aggregatedCell, including the no-custom-cell aggregate formatter path.✅ Checklist
pnpm testandpnpm test:e2e, or these tests do not apply to this pull request.Local checks run:
pnpm --filter @tanstack/table-core exec vitest run tests/unit/flex-render.test.ts tests/implementation/features/row-aggregation/rowAggregationFeature.test.tspnpm --filter @tanstack/table-core exec vitest run --coverage --coverage.reporter=lcov --coverage.reporter=text-summarypnpm --filter @tanstack/table-core test:eslintpnpm --filter @tanstack/table-core test:typespnpm --filter @tanstack/table-core build🚀 Release Impact