Skip to content

fix: allow boolean true in application starter tailwind search param #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 2 commits into from
Oct 24, 2026
Merged

fix: allow boolean true in application starter tailwind search param #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af4beae
fix: allow boolean true in application starter tailwind search param
sentry[bot] Oct 24, 2026
fdb1321
Allow boolean values in ApplicationStarterSearchParams index signature
sentry[bot] Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/application-starter/useApplicationStarterUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ interface ApplicationStarterSearchParams {
template?: string // template preset ID
features?: string // comma-separated feature IDs
pm?: string // package manager: pnpm, npm, yarn, bun
tailwind?: string
tailwind?: 'false' | true
// Feature options serialized as: featureId.optionKey=value
[key: string]: string | undefined
[key: string]: string | boolean | undefined
}

export function useApplicationStarterUrl() {
Expand Down
2 changes: 1 addition & 1 deletion src/routes/application-starter.index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const applicationStarterSearchSchema = v.pipe(
framework: v.optional(v.string()),
features: v.optional(v.string()), // comma-separated feature IDs
pm: v.optional(v.picklist(['pnpm', 'npm', 'yarn', 'bun'])),
tailwind: v.optional(v.literal('false')),
tailwind: v.optional(v.union([v.literal('false'), v.literal(true)])),
tab: v.optional(v.picklist(['summary', 'code', 'preview'])),
file: v.optional(v.string()), // selected file in files tab
addon: v.optional(v.string()), // selected addon in addons tab
Expand Down
2 changes: 1 addition & 1 deletion tests/application-starter-search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ test('application starter preserves optional fields and custom feature options',
},
...['pnpm', 'npm', 'yarn', 'bun'].map((pm) => ({ pm })),
...['summary', 'code', 'preview'].map((tab) => ({ tab })),
{ tailwind: true },
]) {
const result = await standardSchema.validate(input)
assert.equal(result.issues, undefined)
Expand All @@ -41,7 +42,6 @@ test('application starter rejects invalid known fields instead of coercing them'
[],
'name=app',
{ pm: 'deno' },
{ tailwind: true },
{ tailwind: 'true' },
{ tab: 'unknown' },
...[
Expand Down
Loading