Repository navigation
Show Redact feature ranges and lead with TanStack Start - #1423
Conversation
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure and validate lean builds launch/benchmarks/redact-frameworks/measure.mjs, launch/benchmarks/redact-frameworks/serve.mjs, launch/benchmarks/redact-frameworks/browser-checks.json, launch/benchmarks/redact-frameworks/server-checks.json, launch/benchmarks/redact-frameworks/README.md |
The benchmark adds lean variants for Start and Vite, applies their feature options, and checks that each lean build is smaller than its default Redact build. The launcher and check results include the new variants, and the README describes the builds and reproduction steps. |
Record and display lean sizes launch/benchmarks/redact-frameworks/results.json, src/data/redact-framework-sizes.json, src/components/landing/RedactLanding.tsx |
The recorded results and size data add lean measurements for Start and Vite. The landing page displays optional lean-size segments and updates its feature-selection examples. |
Update integration and launch materials launch/redact-next-vinext.md, src/blog/redact-nextjs-vinext.md |
The launch and integration materials reorder Vinext and Next.js references and add Start and Vite setup links and information. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Feature
Possibly related PRs
- TanStack/tanstack.com#1414: Creates the Redact landing page sections that this change updates with framework ordering, lean bundle sizes, and feature examples.
Merge Risk: 
b1d48
-
The benchmark previews and displayed size comparisons are consistent with the recorded results. No issue identified here needs to be resolved before merging.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (7 skipped: 7 … Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names two real changes in the PR: Redact feature ranges (segmented green bars for Start and Vite showing lean-build size ranges, redact-lean results, and the bundle comparison) and the frame… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names two real changes in the PR: Redact feature ranges (segmented green bars for Start and Vite showing lean-build size ranges, redact-lean results, and the bundle comparison) and the framework reorder that leads with TanStack Start (Start, Vite, Vinext, Next.js order in setup tabs, launch copy, and guide links). It is a single, concise sentence, and both parts appear in the raw summary and objectives. It does not cover the benchmark tooling, browser and server checks, or the bundle-size data updates, which is expected for a title of this length.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (7 skipped: 7 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | b1d48fe | Commit Preview URL Branch Preview URL |
Oct 25 2026, 08:10 PM |
Redact now presents frameworks as Start, Vite, Vinext, then Next.js, with Start selected by default. The setup examples, feature examples, launch copy, and guide links use that order.
Start and Vite get segmented green bars showing the measured range from unused features disabled to the default build. Start measures 59.8 to 62.3 KB gzip; Vite measures 12.6 to 20.1 KB. Start retains hydration, context, Suspense, memoization, forwarded refs, lazy components, and class error boundaries. Vinext and Next.js keep solid bars because their integrations use the full runtime. The default comparisons and headline savings are unchanged.
The benchmark now reproduces all ten builds and records their exact sizes, hashes, and feature options. All ten passed browser startup, counter, input, and renderer checks; all seven SSR variants passed the server-rendered content checks. The chart source link pins those measurements to a commit.
Validation: pnpm test passed, including types, lint, 604 unit tests, 2,270 chat tests, and 20 desktop tests. Five existing skips and 104 existing lint warnings remain. Reviewed the chart at 320px, 390px, and 1280px in light and dark themes, and checked all four setup tabs.
Summary by CodeRabbit