Repository navigation
docs(virtual-core): document indexAttribute and test shared-cell measuring - #1387
officialasishkumar wants to merge 1 commit into
Conversation
…uring The indexAttribute option is part of VirtualizerOptions but was only described in the Marko docs. Add an entry to the API reference covering its default, where the attribute is read (measureElement and the resize observer), the warning logged when it is missing, and the grid use case where a row and a column virtualizer measure the same cell through distinct attributes. Add core tests: a row virtualizer and a column virtualizer measure one cell carrying data-row-index and data-column-index and each updates only its own index, and the default attribute / missing-attribute warning behavior. Closes TanStack#1386
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
🎯 Changes
Documents the
indexAttributeoption indocs/api/virtualizer.md(default, where it is read, the warning when it is missing, and the grid case where a row and a column virtualizer measure the same cell through distinct attributes). Adds core tests for that shared-cell case and for the default/missing-attribute behavior.Closes #1386
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit