fix: Misc Bugfixes - #2646
Open
camielvs wants to merge 1 commit into
Open
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
force-pushed
the
08-19-fix_misc_bugfixes
branch
from
August 19, 2026 21:23
b97dd78 to
c2cc417
Compare
camielvs
marked this pull request as ready for review
August 19, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
A batch of small, independent bug fixes. Follow-up to #2645, which fixed subgraph hydration in the run
view — the same class of bug turned out to exist in five other places, and while tracing it I found four
unrelated error-handling bugs worth fixing too.
Subgraphs were invisible to most of the editor. When a pipeline is loaded from YAML, a subgraph
task's contents get moved off
task.componentRefand ontotask.subgraphSpec. Anything still readingtask.componentReftherefore sees an empty shell. #2645 addedtask.resolvedComponentRefto paper overthis; this PR points the remaining readers at it.
componentReffor subgraph contents, found none,and hid itself — so there was no way to unpack a subgraph loaded from YAML.
weren't even flagged as subgraphs, so it couldn't answer questions about them.
nothing inside.
resolvedComponentRefinstead.Error handling. Four unrelated bugs, all in the "silently do the wrong thing" family:
error, we recorded it as "this component is broken" and never tried again — the user had to reload the
page. Real failures now surface so the query layer can retry them. Content that genuinely can't be
parsed is still treated as permanently broken, since retrying that never helps.
spec and a perfectly good URL, we gave up instead of fetching the URL.
null. A spec validator threw aTypeErroronnullinput instead of returningfalse. Previously masked by the error-swallowing above.fetchContainerLognever checked theresponse status, so an error response (the 409 seen while testing fix: Missing Hydration in Run View Subgraphs #2645) got parsed as a log. It now
uses the same
fetchWithErrorHandlinghelper as every other call in that file.before
after
Related Issue and Pull requests
Follow-up to #2645.
Type of Change
Checklist
Test Instructions
Open a pipeline containing a subgraph task that was loaded from YAML (not one built in this session —
the bug only affects deserialized subgraphs).
unpacking should work.
rather than rendering as an empty or malformed log.
Additional Comments
The bulk of the diff in
componentService.tsis re-indentation from removing onetry/catchwrapper —the actual change there is small.
Three existing tests were updated rather than added to: they asserted that storage and crypto errors
return
null, which is exactly the behaviour being fixed. They now assert the error propagates.