feat: Orchestrator - Launchers - Kubernetes - Start labelling created Pods, Jobs and Services with a Tangle label - #341
Conversation
… Pods, Jobs and Services with a Tangle label This is useful to quickly identify objects created by Tangle
|
|
||
| # Kubernetes annotation keys. (Has strict naming policy. Single slash only etc.) | ||
| _CLOUD_PIPELINES_KUBERNETES_ANNOTATION_KEY = "cloud-pipelines.net" | ||
| _TANGLE_KUBERNETES_LABEL_KEY = "tangle.tangleml.com" |
There was a problem hiding this comment.
Question: Would you like me to refactor https://github.com/Shopify/oasis-backend/pull/458 to use this label instead of tangleml.com or refactor this PR to use tangleml.com without the subdomain?
There was a problem hiding this comment.
The default namespace is already created for staging but not yet prod on e09.
There was a problem hiding this comment.
TBH, I do not have an opinion here.
The main reason I added the tangle. prefix was to distinguish Tangle pods from Tangent pods.
I also thought about recent pushes to make Tangent "bigger" than Tangle (although those were scaled down by senior leadership).
I'd say, just proceed with Shopify/oasis-backend#458 as-is. We are already using the tangleml.com in launchers.py. We can refactor all of that later.
2 participants
This is useful to quickly identify objects created by Tangle