fix: sanitize subprocess call in rename.py#709
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
cshilwant
reviewed
May 15, 2026
Member
cshilwant
left a comment
There was a problem hiding this comment.
please plan to address - https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/25904782328/job/76183895662?pr=709
Error: # Commit-Check ❌
Commit rejected by Commit-Check.
(c).-.(c) (c).-.(c) (c).-.(c) (c).-.(c) (c).-.(c)
/ ._. \ / ._. \ / ._. \ / ._. \ / ._. \
__\( C )/__ __\( H )/__ __\( E )/__ __\( C )/__ __\( K )/__
(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)
|| E || || R || || R || || O || || R ||
_.' '-' '._ _.' '-' '._ _.' '-' '._ _.' '-' '._ _.' '-' '._
(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)
`-´ `-´ `-´ `-´ `-´ `-´ `-´ `-´ `-´ `-´
Commit rejected.
Type author_name check failed ==> orbisai0security
The committer name seems invalid
Suggest: git config user.name 'Your Name'
Automated security fix generated by Orbis Security AI Signed-off-by: orbisai0security <mediratta01.pally@gmail.com>
e6d9038 to
b3aa25e
Compare
Author
addressed this. pls review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
bin/rename.py.Vulnerability
V-001bin/rename.py:89Description: The bin/rename.py script constructs a shell command using user-supplied input (filenames or CLI arguments parsed at line 258) and passes the resulting 'command' variable to subprocess.run at line 89. If the command variable is assembled as a string rather than a list, or if shell=True is set, shell metacharacters embedded in user-supplied filenames or arguments will be interpreted by the OS shell, enabling arbitrary command execution. This is a classic OS command injection pattern (CWE-78).
Changes
bin/rename.pyVerification
Automated security fix by OrbisAI Security