mpl: ensure that macros inside a module are kept out of a std cell group - #11147
Open
AcKoucher wants to merge 2 commits into
Open
mpl: ensure that macros inside a module are kept out of a std cell group#11147AcKoucher wants to merge 2 commits into
AcKoucher wants to merge 2 commits into
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the HierRTLMP clustering logic to prevent incorrect instance grouping by adding checks for instance types (isBlock()) relative to the cluster type. It also introduces a new test case, keep_clustering_data2, to verify this behavior. The reviewer suggests an additional improvement to symmetrically skip standard cells when the cluster type is HardMacroCluster to ensure consistency across different cluster types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I had to convert the asserts to production checks to ensure that the new test catches the bug as
addInstactually can move the instance out of its already defined group. So in the regression test, the macro would be assigned to the wrong group, but moved to the correct group.Type of Change
Impact
Groups are correctly created.
Verification
./etc/Build.sh).Related Issues
Found when testing #11122.