rcx: create struct for the unit scale factors to avoid duplicated code on 3D pass - #11176
rcx: create struct for the unit scale factors to avoid duplicated code on 3D pass#11176AcKoucher wants to merge 2 commits into
Conversation
…e on 3D pass Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the scale factor handling in extSpef by introducing a ScaleFactors struct to replace the individual _res_unit and _cap_unit member variables, and encapsulates their calculation into a new static method computeScaleFactors. The feedback suggests renaming computeScaleFactors to computeWriteScaleFactors to clarify its specific use for exporting SPEF and to avoid developer confusion during reading operations. Additionally, it is recommended to change the parameter types from const std::string& to const char* to prevent unnecessary string allocations and safely handle potential null pointers.
| if (capacitance_unit == "PF") { | ||
| scale_factors.capacitance = 0.001; | ||
| } | ||
|
|
||
| if (resistance_unit == "MOHM") { | ||
| scale_factors.resistance = 1000.0; | ||
| } else if (resistance_unit == "KOHM") { | ||
| scale_factors.resistance = 0.001; | ||
| } |
There was a problem hiding this comment.
I know you moved the code be we might as well make it right while we are here
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
2 participants
Summary
We'll use the new struct/method to ensure that all SPEFs have consistent units on #11124.
Type of Change
Impact
None.
Verification
./etc/Build.sh).Related Issues
#11005.