Repository navigation
fix(sorts): stop SwapSort looping forever on duplicate values - #7660
Merged
alxkm merged 2 commits intoOct 27, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7660 +/- ##
============================================
- Coverage 82.23% 82.22% -0.01%
+ Complexity 8399 8398 -1
============================================
Files 843 843
Lines 26134 26138 +4
Branches 5097 5098 +1
============================================
+ Hits 21490 21492 +2
Misses 3853 3853
- Partials 791 793 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rishavbhattarai
marked this pull request as ready for review
October 27, 2026 03:09
Rishavbhattarai
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
October 27, 2026 03:09
alxkm
approved these changes
Oct 27, 2026
alxkm
left a comment
Member
There was a problem hiding this comment.
Looks good. Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwapSortnever finishes when the slot it swaps into already holds an equal value.{2, 2, 1, 1, 0, 0, 0}loops forever: the two2s keep trading places.The fix skips past slots that already hold an equal element before swapping, the same way cycle sort handles duplicates. The copies of
array[index]belong in the slots starting atindex + count.array[index]is one of those copies, so at least one of those slots holds a different value, and the loop stops there.Added a regression test with a 1 second timeout. It times out on
masterand passes with the fix.clang-format -i --style=file path/to/your/file.java