Repository navigation
fix(sorts): keep duplicate values in TreeSort - #7661
Merged
alxkm merged 1 commit intoOct 27, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7661 +/- ##
=========================================
Coverage 82.20% 82.21%
+ Complexity 8397 8396 -1
=========================================
Files 843 843
Lines 26133 26134 +1
Branches 5097 5097
=========================================
+ Hits 21482 21485 +3
+ Misses 3859 3854 -5
- Partials 792 795 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rishavbhattarai
marked this pull request as ready for review
October 27, 2026 03:09
Rishavbhattarai
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
October 27, 2026 03:09
alxkm
approved these changes
Oct 27, 2026
alxkm
left a comment
Member
There was a problem hiding this comment.
Looks good. Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TreeSortloses duplicates.BSTRecursiveGenericignores a key that is already in the tree (on purpose, andBSTRecursiveGenericTest.testDuplicateInsertionschecks it), sosort({-1, -1, 0})returns[-1, 0, 0]: one-1is dropped and the array keeps a stale0in the last slot. TheListoverload returns a shorter list.The fix leaves the BST alone and pairs each element with its input position in a private record, ordered by value and then by position. Equal values stay separate, and the sort is now stable.
TreeSortTestnow extendsSortingAlgorithmTest, like most other sort tests. Onmasterthat brings 6 failures (duplicates, all-identical values, empty strings). With the fix all 44 pass.clang-format -i --style=file path/to/your/file.java