Repository navigation
fix(searches): support characters outside extended ASCII in BoyerMoore - #7664
Open
Rishavbhattarai wants to merge 1 commit into
Open
Rishavbhattarai wants to merge 1 commit into
Rishavbhattarai wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7664 +/- ##
============================================
- Coverage 82.20% 82.18% -0.02%
+ Complexity 8397 8394 -3
============================================
Files 843 843
Lines 26133 26130 -3
Branches 5097 5096 -1
============================================
- Hits 21482 21476 -6
- Misses 3859 3860 +1
- Partials 792 794 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rishavbhattarai
marked this pull request as ready for review
October 27, 2026 03:09
Rishavbhattarai
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
October 27, 2026 03:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoyerMoorekeeps its bad-character table in a 256-entry array indexed bychar, so any character above 255 throws, in the text or in the pattern:The fix stores the table in a
HashMap<Character, Integer>and reads missing characters as -1, which is what the array was filled with. The search loop does not change.clang-format -i --style=file path/to/your/file.java