Skip to content

enhancement - #13307

Open
RuhanikaChotwani wants to merge 2 commits into
TheAlgorithms:masterfrom
RuhanikaChotwani:feature/linear-regression
Open

enhancement#13307
RuhanikaChotwani wants to merge 2 commits into
TheAlgorithms:masterfrom
RuhanikaChotwani:feature/linear-regression

Conversation

@RuhanikaChotwani

@RuhanikaChotwani RuhanikaChotwani commented Oct 7, 2025

Copy link
Copy Markdown

Describe your change:

✅ Add an algorithm

Description:

Added Linear Regression implementations:

Naive implementation using loops for beginners to understand step by step.

Fully vectorized implementation using NumPy for faster and scalable computation.

Includes a test case to verify that both implementations produce similar results.

Added type hints, docstrings, and reference links to Linear Regression concepts for clarity.

Resolves issue #13205(#13205)

  • This pull request is all my own work -- I have not plagiarized.

  • I know that pull requests will not be merged if they fail the automated tests.

  • This PR only changes one algorithm file.

  • All new Python files are placed inside an existing directory.

  • All filenames are in all lowercase characters with no spaces or dashes.

  • All functions and variable names follow Python naming conventions.

  • All function parameters and return values are annotated with Python.

  • All functions have doctests
    that pass the automated testing.

  • Checklist:

  • I have read CONTRIBUTING.md.

  • This pull request is all my own work -- I have not plagiarized.

  • I know that pull requests will not be merged if they fail the automated tests.

  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

  • All new Python files are placed inside an existing directory.

  • All filenames are in all lowercase characters with no spaces or dashes.

  • All functions and variable names follow Python naming conventions.

  • All function parameters and return values are annotated with Python type hints.

  • All functions have doctests that pass the automated testing.

  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.

  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-Upgrade Linear Regression with Fully Vectorized Implementation and add a naive implementation for beginners #13205"

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@RuhanikaChotwani, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot closed this Oct 7, 2025
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2025
@cclauss cclauss reopened this Sep 10, 2026
@algorithms-keeper algorithms-keeper Bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Sep 10, 2026

@algorithms-keeper algorithms-keeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

import numpy as np

# -------------------- Naive Linear Regression --------------------
def naive_linear_regression(X, y, learning_rate=0.01, epochs=1000):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file machine_learning/01_linear_regression.py, please provide doctest for the function naive_linear_regression

Please provide descriptive name for the parameter: X

Please provide descriptive name for the parameter: y

Please provide return type hint for the function: naive_linear_regression. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: X

Please provide type hint for the parameter: y

Please provide type hint for the parameter: learning_rate

Please provide type hint for the parameter: epochs

return theta

# -------------------- Vectorized Linear Regression --------------------
def vectorized_linear_regression(X, y, learning_rate=0.01, epochs=1000):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file machine_learning/01_linear_regression.py, please provide doctest for the function vectorized_linear_regression

Please provide descriptive name for the parameter: X

Please provide descriptive name for the parameter: y

Please provide return type hint for the function: vectorized_linear_regression. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: X

Please provide type hint for the parameter: y

Please provide type hint for the parameter: learning_rate

Please provide type hint for the parameter: epochs

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants