Fixes #13311 Adds SMAPE function to Loss functions - #13355
Merged
Conversation
priya-sundaram-dev
approved these changes
Sep 10, 2026
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
Reviewed. Clean implementation that matches the formula in #13311. I verified the doctest: for [100,200,300,400] vs [110,190,310,420] the SMAPE (fractional form) is ≈0.05702, which matches. Good error path for length mismatch, sensible epsilon guard against a zero denominator, and CI is green.
Note for coordination: #13357 (MAPE) edits the same region of loss_functions.py, so whichever of the two merges second will need a trivial rebase. LGTM. 👍
This was referenced Sep 10, 2026
cclauss
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #13311
Adds the algorithm to calculate symmetric mean absolute percentage error in loss_functions.py file in machine_learning
Checklist: