Skip to content

docs(skill): make the PR checkbox rule a hard final gate #15237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 2 commits into from
Sep 9, 2026
Merged

docs(skill): make the PR checkbox rule a hard final gate #15237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b17f9
docs(skill): make the PR checkbox rule a hard final gate
priya-sundaram-dev Sep 9, 2026
f05e240
docs(skill): wrap long line to satisfy MD013 (350-char limit)
priya-sundaram-dev Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/skills/new-pull-request/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,13 @@ hand. A hand-modified `uv.lock` makes the `algorithms-keeper` bot close the pull
request as invalid, and even a repo maintainer cannot undo that.

Always check at least one Markdown checkbox in the pull request description (the "Describe your change" section), or the
`algorithms-keeper` bot will close the pull request as invalid. Any repo maintainer can undo this if you @mention them on the closed pull request.
`algorithms-keeper` bot will close the pull request as invalid — and it does
this *before* a human reads the PR, so a genuinely good change gets closed for a
formatting reason. This applies to **every** pull request, including CI, docs,
and tooling changes that are not algorithms: tick the boxes that genuinely apply
so the body is never submitted with all boxes empty. Any repo maintainer can
undo this if you @mention them on the closed pull request, but re-opening is
often unreliable, so it is far better to get it right the first time.

### 1. Before contributing / Is this an algorithm?

Expand Down Expand Up @@ -55,3 +61,15 @@ Always check at least one Markdown checkbox in the pull request description (the
- [ ] At least one **Wikipedia (or equivalent) URL** documenting the algorithm.
- [ ] Docstring explains what the function does and its parameters/returns.
- [ ] No unnecessary third-party dependencies.

## Before you click "Create pull request"

This is the final gate. Do not open the pull request until every item here is true:

- [ ] At least one Markdown checkbox in the PR description is checked. **Verify
this by re-reading the rendered body** — if every box is still `- [ ]`, the
`algorithms-keeper` bot will auto-close the PR before any human sees it.
Check the boxes that genuinely apply to this change; never submit an
all-empty checklist, even for a CI, docs, or tooling PR.
- [ ] The branch is not `master`, and `master` is synced with `upstream/master`.
- [ ] `uv.lock` was not hand-edited.
Loading