unify(w3ddisplay): Merge most of W3DDisplay - #3260
Open
stephanmeesters wants to merge 7 commits into
Open
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
| Filename | Overview |
|---|---|
| Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp | Adds display diagnostics, camera, lighting, and shroud behavior; newly added historical-date comments violate an explicit repository rule. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Logic[Game and terrain state] --> Display[W3DDisplay]
Stats[Debug statistics] --> Display
Display --> Terrain[Terrain and shroud rendering]
Display --> Lights[Dynamic light pulses]
Display --> Camera[Letterbox and camera limits]
Display --> Frame[Rendered frame and debug overlay]
Prompt To Fix All With AI
### Issue 1
Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp:2192
**Historical dates violate requirement**
This new comment contains the historical date `8-06-03`. The new letterbox comments at lines 2201 and 2217 similarly contain dates from 2002 and 2003. This violates the repository directive that newly created code comments must not reference dates before 2026, so the comments must be corrected before merging.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (2): Last reviewed commit: "Add physics behavior statistics" | Re-trigger Greptile
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
xezon
approved these changes
Sep 6, 2026
|
Maybe we wait until after #2709 and then merge the rest here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generals gains
dumpStatsto provide additional debug statistics.MSG_META_DEMO_TOGGLE_LETTERBOX, or maybe some scripts in ZH maps need it. Tested with a few Generals cinematics and they appeared the same.TheTerrainRenderObjectinsetShroudLevel(...). This appears to be related to updatingW3DPropBuffer. Should not affect Generals as number of props is always zero.LightEnvironmentClassbefore that flag becomes active in Generals.Note: this is not a full merge of W3DDisplay. Does not unify code touched by #2709.
AI disclosure: AI was used to trace the impact of each of these changes.