Skip to content

build(filesystem): Fix non-Windows path normalization typo - #3412

Merged
xezon merged 1 commit into
TheSuperHackers:mainfrom
bobtista:bobtista/build/fix-normalize-path-typo
Oct 4, 2026
Merged

xezon merged 1 commit into
TheSuperHackers:mainfrom
bobtista:bobtista/build/fix-normalize-path-typo

Conversation

@bobtista

@bobtista bobtista commented Oct 3, 2026 •

Copy link
Copy Markdown

The non-Windows branch of StdLocalFileSystem::normalizePath uses unNormalized instead of the declared nonNormalized variable. Correct the name so the branch compiles.

  • Reproduce the compile error with the extracted function
  • Compile the corrected function and check normalization with both separators

No full game build was run.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9805db7b-e82b-48f0-a4d3-640f680befbd
📥 Commits

Reviewing files that changed from the base of the PR and between 1e39288 and e5b042a.

📒 Files selected for processing (1)
  • Core/GameEngineDevice/Source/StdDevice/Common/StdLocalFileSystem.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


Walkthrough

The non-Windows branch of StdLocalFileSystem::normalizePath now applies backslash-to-forward-slash replacement to nonNormalized instead of the undeclared unNormalized.

Changes

Path normalization

Layer / File(s) Summary
Correct the normalized path reference
Core/GameEngineDevice/Source/StdDevice/Common/StdLocalFileSystem.cpp
The replacement call now uses the declared nonNormalized string.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: xezon

Merge Risk: ⚪ Minimal · up to e5b04

The non-Windows normalization compile issue is corrected, and the full change shows no remaining actionable regression.

Architecture Summary

Architecture risk: 🔵 Low · up to e5b04

The change affects 1 system.

Changed systems: Core

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Core (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in Core/GameEngineDevice/Source/StdDevice/Common/StdLocalFileSystem.cpp: normalizePath now replaces backslashes in nonNormalized instead of unNormalized.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #3411 requires the non-Windows branch of StdLocalFileSystem::normalizePath to compile without the undeclared unNormalized error. The PR changes the std::replace call to use the declared `n…
Out of Scope Changes check ✅ Passed The only change replaces unNormalized with nonNormalized in the exact function and branch described by issue #3411. The change is within scope.
Title check ✅ Passed The title clearly identifies the non-Windows path normalization fix.
Description check ✅ Passed The description explains the undeclared variable fix and the reported compile and normalization checks.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Fixes a typo in file path normalization on non-Windows systems.

The PR appears safe to merge based on the reviewed change.

Summary

Fixes a variable-name typo in the non-Windows path-normalization branch so it can compile and convert backslashes to forward slashes.

  • The change is limited to the variable passed to std::replace.
  • No full game build was run, as noted in the PR description.

Reviews (1) · Last reviewed commit: "build(filesystem): Fix non-Windows path ..."

@Caball009 Caball009 added CompileBug Bug at compile time ThisProject The issue was introduced by this project, or this task is specific to this project Build Anything related to building, compiling labels Oct 4, 2026
@Caball009

Copy link
Copy Markdown

That function is quite a mess... AsciiString -> std::string -> std::fs_path -> AsciiString.

@xezon
xezon merged commit f8ba7eb into TheSuperHackers:main Oct 4, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Anything related to building, compiling CompileBug Bug at compile time ThisProject The issue was introduced by this project, or this task is specific to this project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-Windows path normalization references an undeclared variable

3 participants