Skip to content

Contributing.md mentions root npm run build / test:e2e, but neither exists #240

Description

@crazy-explore-r

While setting up the repo I noticed the Testing section in wiki/Contributing.md tells contributors to run:

npm run build
npm run test:e2e

and says npm run build is "the repository static asset validator" and npm run test:e2e runs Playwright.

Problem is, none of that exists at the repo root — there's no root package.json, no Playwright config anywhere, and no test:e2e script. If you git clone and try it fresh, npm run build just fails with no package.json found. The only real npm run build lives inside desktop-app/, and it builds the Neutralino standalone binaries, not a static asset validator. Checked .github/workflows/desktop-build.yml too and that's the only place npm actually runs in CI, scoped to desktop-app/.

So either these root scripts were planned but never added, or the docs are just out of date. Either way it's a rough first impression for anyone following Contributing.md step by step.

Happy to send a docs PR to fix the Testing section to match what's really there, if that's the preferred direction over adding the missing scripts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions