Remove static libraries from final build of tiledb-r on Windows#816
Merged
mojaveazure merged 2 commits intomainfrom Apr 24, 2025
Merged
Conversation
R 4.5 has begun introducing checks of static libraries bundled as part of the package; this PR removes said static libraries as they were failing CRAN checks
jp-dark
approved these changes
Apr 23, 2025
ihnorton
approved these changes
Apr 23, 2025
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
Change LGTM but I'm unclear if we are running the same check CRAN is on Windows, because I don't see any failures for this reason in recent builds
Member
Author
|
@ihnorton Here are the logs from win-builder for this branch; the one warning is because I built the tarball on Windows, which is configured to checkout from Git with CRLF line endings; building the tarball under macOS/Linux will solve that warning |
teo-tsirpanis
approved these changes
Apr 23, 2025
Member
Author
|
For reference, here are the win-builder logs for |
Bump develop version
mojaveazure
deleted the
paulhoffman/sc-65372/r-compiled-code-in-inst-tiledb-libs-is-invalid
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R 4.5 has begun introducing checks of static libraries bundled as part of the package; this PR removes said static libraries as they were failing CRAN checks
SC-65372