Repository navigation
Expand the soundness fuzzer's model pools and grammar - #10
Open
tilorc-bot wants to merge 1 commit into
Open
tilorc-bot wants to merge 1 commit into
tilorc-bot wants to merge 1 commit into
Conversation
Cover the blind spots the adversarial audit named: declared symbols (n, ni, xi) with declaration-respecting pools, infinities and undefined values, evaluate=False powers, acos/factorial, extended-real predicates, and matrix expressions with element-predicate expansion. On the sathandlers tip this found a regression: _pow_real_facts compares a Number exponent against zero, so a nan exponent raises TypeError (Invalid NaN comparison). main returns None and sympy.ask answers None. The curated list pins the reduced query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The adversarial audit in #9 listed the query classes the soundness fuzzer could
not generate; this closes them so the remaining handler fixes can be verified
randomly instead of only by targeted probing.
What
n,ni,xi, withpools filtered by the declared assumptions),
oo/-oo/zoo/nan,evaluate=Falsepowers,acos/factorial, and the extended-real predicates.MatMul,MatPow,HadamardProduct,Transpose,MatrixSlice,ZeroMatrix) and element predicates are expandedwith
as_explicit, becauseaskdoes not decide them for explicit matrices.handler code is touched.
Finding
On #9's tip the expanded grammar found a regression reduced to:
reasoning/sathandlers.py:468doesisinstance(exp, Number) and exp < 0, andS.NaNis aNumber, sonan < 0raises.mainreturnsNone; the curatedlist now pins the query. It should be fixed on
fix/sathandlers-scalar.Verification
fix/sathandlers-matrixfactscd0a061: adversarial + matrixfacts suites21 passed / 9 xfailed (all scalar), and 200 Hypothesis examples find nothing
beyond the
nancrash.main, curated: 0 findings; Land sathandlers with sound Pow, matrix and function guards #9 tip, curated: thenancrash only.pytest reasoning/tests: 164 passed, 1 xfailed;mypyclean.This description was written by an AI agent (opencode, deepseek-v4.1-flash) on
behalf of TiloRC.